Add variable length argument lists to commands contruct as an array

joselfonseca / laravel-tactician

Laravel Tactician is an implementation of the Command Bus Tactician by Ross Tuck.

MIT License

61 stars 12 forks source link

Closed jagarsoft closed 6 years ago

jagarsoft commented 6 years ago

Hello

I'm proud by contributing with a feature that allows to make Command with a variable length of args in __construct

joselfonseca commented 6 years ago

Hello @jagarsoft thanks for your PR! could you please check why the tests are not passing https://travis-ci.org/joselfonseca/laravel-tactician/jobs/441936189 also can you please fix the NitPick suggestions, once all that is in green I will check it in detail.

Happy coding!

joselfonseca commented 6 years ago

Thanks, this is now in V0.5

jagarsoft commented 6 years ago

Hi again! Thanks for accepting this PR!!! An remaining doubt, btw ;-) Why did you tagged as 0.5.0 instead of just 0.4.2?