joshmarinacci / ElectronIDE

New web based Arduino IDE
BSD 3-Clause "New" or "Revised" License
246 stars 50 forks source link

auto-opens the default browser #38

Closed wturyn closed 9 years ago

wturyn commented 10 years ago

Small feature that, after initiating the server, opens the default browser with correct location and port.

joshmarinacci commented 10 years ago

Hmm. I'm not sure about this. How cross platform is the 'open' library?

riban-bw commented 10 years ago

This patch works in Ubuntu 14.04. Not sure it is entirely desirable. Whilst testing one may be restarting backend several times whilst keeping web browser open. This creates a new tab in the web browser in addition to the one already open.

wturyn commented 10 years ago

@joshmarinacci: I've tested it in Windows 7 and Ubuntu 14.04. I'm pretty sure it works properly also in darwin systems.

@riban-bw: maybe it should be configurable - in setttings.js for example.

joshmarinacci commented 9 years ago

I've decided against this feature because soon we will have the browser embedded in the app anyway. I appreciate the effort, though. Thank you.