search

joshmarinacci / ElectronIDE

New web based Arduino IDE
BSD 3-Clause "New" or "Revised" License
246 stars 50 forks source link

Public javascript cleanup #45

Closed wturyn closed 10 years ago

wturyn commented 10 years ago

Hi Joshua, this is my proposal for basic clean up of front-end javascript. I've moved almost all inline code to module js/ElectronIDE.js. I've also seperated definitions from initialisation calls (moved to init method) and cleaned up formatting. $(document).ready now calls only ElectronIDE.init().

IMHO this is more readable now, but with more features it will get messy again, so more modularisation may be required. Have You considered using some proper SPA framework? AngularJS maybe?

joshmarinacci commented 10 years ago

Amazing work. Thank you. Yes, long term I plan to move to a proper framework. I've heard good things about Angular.

PixnBits commented 10 years ago

I have an angular branch that might be a good start. (I use Angular a lot at work and got a bit excited)

PixnBits commented 10 years ago

opened #46 for further discussion