search

jotyGill / openpyn-nordvpn

Easily connect to and switch between, OpenVPN servers hosted by NordVPN on Linux (+patch leakes)
GNU General Public License v3.0
628 stars 114 forks source link

Some minor fixes #221

Closed 1951FDG closed 5 years ago

1951FDG commented 5 years ago

193f578 -- useful for later, when constant 3 can be changed, when we would want both retries and top_servers to be == 1, for ssh command mode (one time command mode), basically I'm thinking an argument to be supplied to openpyn, for number of retries, I could use your feedback on this, the idea in the end is "one time connect mode" with no retries, and clean exit after connect() (so connect() would have to be changed a little as well, so that openvpn is executed differently)

f9cb261 -- pretty important bugfix, tested on macOS and Asuswrt-merlin

35bfb19 -- performance fix

1951FDG commented 5 years ago

Hi, small reminder, could you incorporate these changes into test as well? thanks!