search

jotyGill / openpyn-nordvpn

Easily connect to and switch between, OpenVPN servers hosted by NordVPN on Linux (+patch leakes)
GNU General Public License v3.0
628 stars 114 forks source link

RFC: Adding more options to expose ports while firewall is added #228

Open ryanolee opened 5 years ago

ryanolee commented 5 years ago

Hi @jotyGill , Thanks for making this project! I have found it very helpful in dealing with nordVPN on linux.

During the process of using the firewall option I ran into a few issues when setting up things like uPnP av given it was hard to specify specific port rules.

I would therefore as an extension of https://github.com/jotyGill/openpyn-nordvpn/issues/207 and https://github.com/jotyGill/openpyn-nordvpn/issues/38 like to prepose a mechanism for customising more elements of the ports exposed when the firewall is active.

I have opened up a PR with a POC for how this might work here.

Any comments on this would be much appreciated!

jotyGill commented 5 years ago

Hi @ryanolee , Thanks mate, glad it's helpful :) That's great! I was thinking of doing something similar at some point. I'll have to go through it and see if it all works out. I really should clarify it on the project that I do all the development in the 'test' branch. ATM it's 50 commits ahead of master and I am yet push more and 1951FDG has some pending (there are bunch of merge conflicts already). We are going to have to merge this into the 'test' branch instead. If I manually merge it (copy paste) it into test after the other things, it won't show up as your contribution, I don't wanna do that. I guess you should wait a little, hopefully I'll sort out the other things tomorrow then you could pull the 'test' branch and put your changes in it.

Cheers

ryanolee commented 5 years ago

Hi @jotygill, No worries I will rebase onto the test branch tomorrow and repoint my PR to merge into test 😁 Thanks!

ryanolee commented 5 years ago

Hi @jotyGill, I have rebased onto the latest changes in the test branch It might need some refactoring as it was a copy and paste job on my end. Will need to verify if it still works 🤔