Bugfixes and new features for NVRAM users, external app users

jotyGill / openpyn-nordvpn

Easily connect to and switch between, OpenVPN servers hosted by NordVPN on Linux (+patch leakes)

GNU General Public License v3.0

628 stars 114 forks source link

Bugfixes and new features for NVRAM users, external app users #254

Closed 1951FDG closed 4 years ago

1951FDG commented 4 years ago

Hi there,

It's been a while, but I've finally got around to spend some time coding on Openpyn, still busy working on the Android app which is currently still in beta.

4 Bugfixes
2 Features

Fixed a couple of inspection warnings, sorted imports, corrected typos and I also updated the readme file!

jotyGill commented 4 years ago

Hey Derrick, how are you going mate? Thanks for the pull. I'll have go through all the changes here.

Over the holidays I'll be getting back to working on openpyn and push the next major version 3.0 One thing; I would like to keep the args posix style (https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html) Could you change these to let's say.

'-app', '--application' '-loc', '--location'

'-A', '--application' '-L', '--location' I am open to suggestions for different letters or only using the -- versions.

Cheers, Gill

1951FDG commented 4 years ago

Hey Gill,

Doing alrighty, how about you?

I guess we could use -- versions, since I'm not sure about '-L' since '-l' is used for list, or maybe rename the arguments?

To be honest, feel free to modify the arguments as you see fit, since I can change them in the android app afterwards. I won't be able to push any changes until beginning of January 2020.

Happy holidays!