search

jpamental / typogrify

Drupal 8 port of the Typogrify module
GNU General Public License v2.0
3 stars 4 forks source link

Migrate code into plugin #3

Closed Greg-Boggs closed 8 years ago

Greg-Boggs commented 8 years ago

The module still doesn't function, but this is a much stronger starting point because I've migrated the D7 functional hooks into the d8 filter plugin system.

Added a few fixme's where needed.

Big Todos:

  1. Migrate the dependencies to the autoloader/namespace business
  2. Allow composer support
  3. Add dependencies with composer (perhaps)
  4. fix the rest of the fixmes
  5. Test

~Greg

jpamental commented 8 years ago

Greg - I've merged in Rob's PRs. Can you have a look at yours and see if theres still updates that can be merged in? I honestly don't know enough to look at the code and know if it's a complete overlap or not.

Thanks!

Greg-Boggs commented 8 years ago

@jpamental No worries I'll update my PR so it merges tomorrow.

Greg-Boggs commented 8 years ago

Ok @jpamental, the PR is updated and will merge now. The code is only about 80% done. Items that aren't done are marked with @fixme. For example, line 28 of initsubscriber.php.