search

jpamental / typogrify

Drupal 8 port of the Typogrify module
GNU General Public License v2.0
3 stars 4 forks source link

resolve some fatal errors #4

Closed Greg-Boggs closed 8 years ago

Greg-Boggs commented 8 years ago

This PR gets the module closer to working. But, it still does not work because plugins for D8 don't allow you to dynamically add new settings on form submit. So, we'll have to find a work around for this still.

jpamental commented 8 years ago

I wonder if we need to look at some other input filter modules for clues. Clearly we can't be the only ones with this scenario!

Greg-Boggs commented 8 years ago

Yea... It might be as simple as hard coding a known list, or pulling the list from config instead of computing it on load. I am not super familiar with the module or what those settings do. Hopefully someone who uses the module will jump in and help out?

We could also just remove the features that aren't working yet because the majority work, if we remove the broken ones.

jpamental commented 8 years ago

I’ve been using it for years in D6 and 7 but will look again at the code that’s causing the issue.

On Jul 27, 2016, at 12:24 PM, Greg Boggs notifications@github.com wrote:

Yea... It might be as simple as hard coding a known list, or pulling the list from config instead of computing it on load. I am not super familiar with the module or what those settings do. Hopefully someone who uses the module will jump in and help out?

We could also just remove the features that aren't working yet because the majority work, if we remove the broken ones.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jpamental/typogrify/pull/4#issuecomment-235640470, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgzRWHqUUx33yj0XRGsKgifJZvgoWffks5qZ4ZUgaJpZM4JJrta.