jpmorganchase / jupyter-fs

A filesystem-like contents manager for multiple backends in Jupyter
Apache License 2.0
200 stars 36 forks source link

Add proper JupyterLab theming support #161

Closed vidartf closed 12 months ago

vidartf commented 1 year ago

Uses lab CSS variables to theme the treefinder. This includes injecting styles into icons.

Other things in this PR:

github-actions[bot] commented 1 year ago

Binder Launch a binder notebook on branch jpmorganchase/jupyter-fs/theme

github-actions[bot] commented 1 year ago

Test Results

  3 files  ±0    5 suites  ±0   52s :stopwatch: +17s 15 tests +7  15 :heavy_check_mark: +7  0 :zzz: ±0  0 :x: ±0  17 runs  +7  17 :heavy_check_mark: +7  0 :zzz: ±0  0 :x: ±0 

Results for commit 4cfac669. ± Comparison against base commit 49ffa3ea.

This pull request removes 3 and adds 10 tests. Note that renamed tests count towards both. ``` jupyterfs.tests.test_fsmanager.Test_FSManager_osfs ‑ testWriteRead jupyterfs.tests.test_fsmanager.Test_FSManager_s3 ‑ testWriteRead jupyterfs.tests.test_fsmanager.Test_FSManager_smb_docker_share ‑ testWriteRead ``` ``` jupyterfs.tests.test_fsmanager.Test_FSManager_osfs ‑ test_write_read[jp_server_config0] jupyterfs.tests.test_fsmanager.Test_FSManager_osfs ‑ test_write_read[jp_server_config1] jupyterfs.tests.test_fsmanager.Test_FSManager_s3 ‑ test_write_read[jp_server_config0] jupyterfs.tests.test_fsmanager.Test_FSManager_s3 ‑ test_write_read[jp_server_config1] jupyterfs.tests.test_fsmanager.Test_FSManager_smb_docker_share ‑ test_write_read[jp_server_config0] jupyterfs.tests.test_fsmanager.Test_FSManager_smb_docker_share ‑ test_write_read[jp_server_config1] jupyterfs.tests.test_metamanager ‑ test_client_creation_disallowed[our_config0] jupyterfs.tests.test_metamanager ‑ test_client_creation_disallowed_retains_server_config[True-our_config0] jupyterfs.tests.test_metamanager ‑ test_resource_validators[our_config0] jupyterfs.tests.test_metamanager ‑ test_resource_validators_no_auth[our_config0] ```

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 70.76% and project coverage change: +10.36 :tada:

Comparison is base (49ffa3e) 40.50% compared to head (4cfac66) 50.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #161 +/- ## =========================================== + Coverage 40.50% 50.86% +10.36% =========================================== Files 23 25 +2 Lines 1153 1325 +172 Branches 143 172 +29 =========================================== + Hits 467 674 +207 + Misses 643 587 -56 - Partials 43 64 +21 ``` | [Impacted Files](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase) | Coverage Δ | | |---|---|---| | [js/src/index.tsx](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase#diff-anMvc3JjL2luZGV4LnRzeA==) | `19.40% <5.00%> (-8.86%)` | :arrow_down: | | [jupyterfs/fsmanager.py](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase#diff-anVweXRlcmZzL2ZzbWFuYWdlci5weQ==) | `45.39% <52.38%> (+4.40%)` | :arrow_up: | | [jupyterfs/pathutils.py](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase#diff-anVweXRlcmZzL3BhdGh1dGlscy5weQ==) | `70.49% <66.66%> (+39.34%)` | :arrow_up: | | [jupyterfs/tests/utils/client.py](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase#diff-anVweXRlcmZzL3Rlc3RzL3V0aWxzL2NsaWVudC5weQ==) | `77.27% <77.27%> (ø)` | | | [jupyterfs/metamanager.py](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase#diff-anVweXRlcmZzL21ldGFtYW5hZ2VyLnB5) | `71.14% <86.66%> (+38.32%)` | :arrow_up: | | [jupyterfs/tests/test\_metamanager.py](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase#diff-anVweXRlcmZzL3Rlc3RzL3Rlc3RfbWV0YW1hbmFnZXIucHk=) | `97.91% <97.91%> (ø)` | | | [jupyterfs/config.py](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase#diff-anVweXRlcmZzL2NvbmZpZy5weQ==) | `100.00% <100.00%> (ø)` | | | [jupyterfs/tests/conftest.py](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase#diff-anVweXRlcmZzL3Rlc3RzL2NvbmZ0ZXN0LnB5) | `83.33% <100.00%> (+1.51%)` | :arrow_up: | | [jupyterfs/tests/test\_extension.py](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase#diff-anVweXRlcmZzL3Rlc3RzL3Rlc3RfZXh0ZW5zaW9uLnB5) | `100.00% <100.00%> (ø)` | | | [jupyterfs/tests/test\_fsmanager.py](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase#diff-anVweXRlcmZzL3Rlc3RzL3Rlc3RfZnNtYW5hZ2VyLnB5) | `98.97% <100.00%> (+0.18%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/jpmorganchase/jupyter-fs/pull/161/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jpmorganchase)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

timkpaine commented 12 months ago

done in https://github.com/jpmorganchase/jupyter-fs/pull/174