working on ci switch to gha / jupyterlab 4 support

jpmorganchase / jupyter-fs

A filesystem-like contents manager for multiple backends in Jupyter

Apache License 2.0

200 stars 36 forks source link

working on ci switch to gha / jupyterlab 4 support #162

Closed timkpaine closed 12 months ago

github-actions[bot] commented 1 year ago

Launch a binder notebook on branch jpmorganchase/jupyter-fs/tkp/ci

timkpaine commented 1 year ago

Status:

[x] working on JupyterLab 4.0 (minimal changes, just had to deal with hidden)
[x] Linux / Docker based CI seems to be working, moved from explicit invocation of images to using podman-compose to run the docker images all together
[ ] Having difficulties getting samba running properly on my Mac, but will also test that
[ ] Need to setup windows share drive testing to match appveyor

github-actions[bot] commented 1 year ago

Test Results

  3 files   5 suites 41s :stopwatch:   8 tests   8 :heavy_check_mark: 0 :zzz: 0 :x: 10 runs 10 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 6b9f28c1.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@4865c08). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #162 +/- ## ======================================= Coverage ? 40.51% ======================================= Files ? 24 Lines ? 1160 Branches ? 145 ======================================= Hits ? 470 Misses ? 647 Partials ? 43 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

timkpaine commented 1 year ago

someone with admin will need to adjust the expected status checks, I think the appveyor builds are no longer running and we'll want to switch over to the GHA build once this is merged.

Also if someone could take care of the codecov integration above (@jpmtrm)

vidartf commented 1 year ago

I appreciate the work here! Could we split the lab 4 update into a separate PR? We have a bunch of changes that we plan to merge and release against 3.x, and it would be great to have CI for those.

timkpaine commented 1 year ago

rebase on https://github.com/jpmorganchase/jupyter-fs/pull/165 when merged

timkpaine commented 1 year ago

https://github.com/jupyterlab/jupyterlab/issues/14590

timkpaine commented 12 months ago

done in https://github.com/jpmorganchase/jupyter-fs/pull/174