search

jpmorganchase / jupyter-fs

A filesystem-like contents manager for multiple backends in Jupyter
Apache License 2.0
200 stars 36 forks source link

Setup of jupyter-fs configuration doesn't work #197

Closed tristanbrown closed 6 months ago

tristanbrown commented 6 months ago

Describe the bug After starting jupyterlab, jupyter-fs remains grayed-out as an extension. Configuration of jupyter-fs exists in the advanced settings editor, but does nothing.

My startup logs relevant to jupyter-fs look like this:

2024-03-13 17:34 : /opt/conda/lib/python3.9/site-packages/jupyterfs/extension.py:42: UserWarning: Misconfiguration of MetaManager. Please add:
2024-03-13 17:34 : "ServerApp": {
2024-03-13 17:34 :   "contents_manager_class": "jupyterfs.metamanager.MetaManager"
2024-03-13 17:34 : }
2024-03-13 17:34 : to your Notebook Server config.
2024-03-13 17:34 :   warnings.warn(_mm_config_warning_msg)
2024-03-13 17:34 : [I 2024-03-13 17:34:58.024 ServerApp] jupyterfs.extension | extension was successfully loaded.

To Reproduce Steps to reproduce the behavior:

  1. pip install jupyter-fs
  2. create the ~/.jupyter/jupyter_server_config.json file as described in the README
  3. start the jupyterlab server

I've also tried all of the configuration files described here and here in ~/.jupyter/ with no luck.

Expected behavior Updating jupyter-fs configurations in the advanced settings editor should create new fs tabs on the sidebar.

Desktop (please complete the following information):

Additional context I'm running jupyterlab==3.6.7 and jupyter-fs==0.3.1

timkpaine commented 6 months ago

Unfortunately Jupyter has a few different config files right now. You should look at jupyter --paths, and look for jupyter_{notebook,lab,server}_config.py. If nothing is present, you can also try jupyter lab --generate-config and it should tell you what file to use.

tristanbrown commented 6 months ago

Can you clarify? Out of the jupyter --paths I see, only /opt/conda/etc/jupyter contains any preexisting config files. But modifying these doesn't seem to change anything.

If I use jupyter lab --generate-config, it creates ~/.jupyter/jupyter_lab_config.py, but it's not completely clear which options I'm supposed to put in the .py version of config to make jupyter-fs work. I tried including c.ServerApp.contents_manager_class = 'jupyterfs.metamanager.MetaManager', but again, nothing changes.

Would it be possible for jupyter-fs to set up the proper config upon install?

timkpaine commented 6 months ago

Just to clarify, you did 

import jupyterfs 
c.ServerApp.contents_manager_class = jupyterfs.metamanager.MetaManager

not a string, correct? I believe setting in a python config file vs a json config file requires some changes from the readme.

tristanbrown commented 6 months ago

Okay, that worked, but now I'm running into the same "empty panel" issue described in https://github.com/jpmorganchase/jupyter-fs/issues/187.

timkpaine commented 6 months ago

Ok cool going to close this and followup on that thread, might be an issue with newer jlab.