search

jpraus / arduino-opentherm

Arduino library and hardware shield to send and receive data from Opentherm devices
Other
160 stars 42 forks source link

Probably wrong Data ID for Master Version #33

Closed Kira-sempai closed 3 years ago

Kira-sempai commented 3 years ago

https://github.com/jpraus/arduino-opentherm/blob/d9f34280fd747ac8769edfaba71fc600c3b40c46/src/opentherm.h#L81

In my doc there is 126, not 128.

Btw, why do you use defines for ID's and not enum? Enum are simpler and fewer mistakes can be made.