jsakamoto / Toolbelt.Blazor.I18nText

The class library that provides the ability to localize texts on your Blazor app!
Mozilla Public License 2.0
246 stars 23 forks source link

Issue with VS Mac #32

Open NPadrutt opened 4 years ago

NPadrutt commented 4 years ago

I have an issue with loading my project in Visual Studio Mac. After some investigation it turned out that it handles the Link in the Targets of the l18nText not correctly. Whilst that seems to be something VS should be able to handle, the developer from Microsoft pointed out an improvement who could be made in the library. So I thought I post that here:

Whilst Visual Studio for Mac should handle this (I am assuming it works on Windows) it looks like this could be fixed in the NuGet package itself. It has:

https://github.com/jsakamoto/Toolbelt.Blazor.I18nText/blob/bdd176733cb028a63a2b0ee8a72ba85bb9793ba0/Toolbelt.Blazor.I18nText/build/Toolbelt.Blazor.I18nText.targets#L23

<Link>..\..\..\obj\$(Configuration)\$(TargetFramework)\%(RelativeDir)%(Filename)%(Extension)</Link> Which does not look correct to me. The first part of this should be $(IntermediateObjectPath) since you can override the BaseIntermediateOutputPath (usually obj) to be something else.

Here is the Link to the Discussion in the developercommunity: https://developercommunity.visualstudio.com/content/problem/1073405/invalid-value-for-link-property.html?childToView=1075313#comment-1075313

jsakamoto commented 4 years ago

@NPadrutt Thank you for notify me!

Yeah, this is the "dirty hack" based on that I don't have enough skill of MSBuild script. So I have to fix this.

I'll challenge to solve this issue. Or else, of course, If somebody fixes this issue and send me a pull request, I'll welcome it.

jsakamoto commented 4 years ago

@NPadrutt Today, I published a new version of "Blazor I18text" NuGet package v.9.1.1.

Would you try this version on your Visual Studio for Mac environment?

Thanks!

NPadrutt commented 4 years ago

for me it seems to persist.