jscastro76 / threebox

A Three.js plugin for Mapbox GL JS, with support for animations and advanced 3D rendering.
Other
551 stars 146 forks source link

Progressive load of objects only if they are in the current viewport #10

Open jscastro76 opened 4 years ago

jscastro76 commented 4 years ago

Check if a GeoJSON source is present in mapbox viewport Mapbox queryRenderedFeatures

joedjc commented 4 years ago

@jscastro76 Firstly it's great to see this library being taken further with many useful features.

As a thought on this - we've been wondering how we could improve the performance of lots of 3D elements using LOD, meshes etc. I was wondering if you'd had any thoughts on the use of 3D tiles, which could be streamed from a server?

I saw some examples here: https://github.com/Geodan/mapbox-3dtiles https://github.com/Geodan/pg2b3dm

Which I thought were interesting. Maybe not appropriate for threebox and slightly different use case to using GeoJSON

jscastro76 commented 4 years ago

Hi @joedjc, Sorry for this delayed reply, I've been buried under a ton of work this week. Regarding your questions, I'm definitely interested in LOD because of the potential performance improvement, I need that feature as a priority. I opened an issue #9 on that topic. On the other side, I'm not interested (yet) on any 3D tiling like those ones from Geodan or this one from the original creator of this repo, or this one from Mapbox. I read in an issue that I opened to Mapbox that they are already working on 3D tiling as they discussed around the use of term altitude or z or elevation or offset... it was West Langley so I guess this will come directly from Mapbox.