jscastro76 / threebox

A Three.js plugin for Mapbox GL JS, with support for animations and advanced 3D rendering.
Other
550 stars 145 forks source link

Support for MapLibre V2? #375

Closed John2397 closed 1 year ago

John2397 commented 1 year ago

Recently, I migrated from Mapbox V1 to Maplibre V1 as Mapbox became closed source. Since Maplibre V1 is completely backwards compatible with Mapbox V1, the only thing I had to change was the CDN links and replace everywhere the word mapboxgl with maplibregl.To my surprise, threebox was working seamlessly as well.

However, when I tried to update Maplibre V1 to Maplibre V2, I got the following errors coming from threebox: Screenshot from 2022-11-10 11-37-39 which indicates incompatibility between them (I suppose?).

My question is, are there any plans on the table to make threebox compatible with Maplibre V2?

tovaz commented 1 year ago

Hello; I got same issue; Decrease Threebox version number to V 2.2.1 it works; But the objects are not updating while changing color or hidden propertie;

Captura de pantalla 2022-11-10 a las 12 09 08

So that means; we need to rewrite our current code; but I still think is not the solution, maybe it wont work anyway. better could be some threebox member fix this issue;

Do some one else faced that issue ?

MrDevAjay commented 1 year ago

I also have this same issue. 3D icons are not showing. can not read propertied of undefined 'position' error is showing

jscastro76 commented 1 year ago

Thanks for reaching out @John2397, @tovaz, @MrDevAjay! This plugin was not implemented to be compatible with MapLibre but Mapbox and AzureMaps on the versions supported and described by the README.md, I'm indeed surprised it still worked on another maps' engine. But as this repo is MIT license, you have rights to fork the project to create your own implementation.

douglasg14b commented 1 year ago

@jscastro76 You should really reconsider this as a hard wontfix. Maplibre IS mapbox before they went proprietary, it's the community fork of it. It's not a different engine

But as this repo is MIT license, you have rights to fork the project to create your own implementation.

Community fragmentation makes these issues worse, not better :(

Just found this project and was super excited, but since it's proprietary mapbox only, and doesn't support the community mapbox fork, it's kind of a bummer.

How much work would you think would be necessary here?

jscastro76 commented 1 year ago

Thanks @douglasg14b for your feedback! This code is already in production in different projects using Mapbox and Azure Maps, which are the platforms it was designed and implemented for. It's been downloaded 160K times as NPM module, there are +100 forks and reused by hundreds of other projects. As said, this is an open source project under MIT license, which gives you a lot of benefits and rights completely for free, but this is not a Support desktop with an SLA, so if you have this need, you can implement it by yourself and contribute to the project with a PR, and in the case the tests and current examples still working, I'll be glad to add it to the code and publish a new version.

nicky132 commented 1 year ago

image Hope someone do anything about threebox to support maplibre2