tb must set global var (fix)

jscastro76 / threebox

A Three.js plugin for Mapbox GL JS, with support for animations and advanced 3D rendering.

Other

549 stars 145 forks source link

tb must set global var (fix) #423

Open iimrudy opened 4 months ago

iimrudy commented 4 months ago

Hello,

I've managed to remove the must set global var everywhere because i was having some trouble with it. I've also did some testing and everything seems to be working fine. I've also added some types for typescript into the index.d.ts. idk if they are working right or what... let me know if i have to fix something :)

any change to get the new release of threebox? it would be very usefull to me (and i think to some other users that already reported this bug :) )

Thanks.

Clamb94 commented 1 month ago

Looks like your auto-formatter has changed a lot of small stuff, like replacing " with '. To have a better overview over this PR, it would probably make sense to revert that.