jschalk / jaar

Cross-cultural communication engine built on customizable economic systems. Produces personalized agendas, calendars, finance reports for users.
0 stars 1 forks source link

283 refactor the range management system in ideaunits #287

Closed jschalk closed 2 months ago

jschalk commented 2 months ago

time refactoring and feature adding. Still under development

Summary by Sourcery

Refactor the range management system by replacing 'jajatime' with 'gregtime', introducing new attributes for range calculations, and improving exception handling. Update tests to cover new functionalities and changes.

Enhancements:

Tests:

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request refactors the range management system in the 'ideaunits' module. It introduces new attributes and methods for handling ranges, removes deprecated code, and updates related tests and examples. The changes aim to improve the efficiency and clarity of range-related operations within the project.

File-Level Changes

Change Details Files
Refactored range management system in ideaunits
  • Replaced '_reest' attribute with '_morph'
  • Introduced '_gogo_want' and '_stop_want' attributes
  • Removed '_numeric_road' and '_range_source_road' attributes
  • Added '_range_pushs' attribute
  • Introduced new methods for range calculations and transformations
  • Updated related tests and examples to use new range system
src/bud/idea.py
src/bud/bud.py
src/bud/test_bud/test_bud_idea_crud.py
src/bud/test_bud_settle/test_tree_traverse_base.py
src/bud/test_bud_settle/test_z_agenda.py
src/bud/test_bud_settle/test_tree_traverse_reason_idea.py
src/bud/test_bud/test_bud_idea_label_edit.py
src/bud/test_bud_settle/test_tree_traverse_fund_distribution.py
src/bud/examples/example_bud1.json
Renamed 'jajatime' to 'gregtime'
  • Updated all occurrences of 'jajatime' to 'gregtime'
  • Modified related tests and examples
src/bud/examples/example_bud2.json
src/bud/test_bud_settle/test_z_agenda.py
src/bud/test_bud_settle/test_tree_traverse_fund_distribution.py
Removed deprecated time-related code and files
  • Deleted 'src/bud/bud_time.py'
  • Deleted 'src/bud/test_bud_settle/test_tree_traverse_set_fact.py'
  • Deleted 'src/bud/examples/example_time.py'
src/bud/bud_time.py
src/bud/test_bud_settle/test_tree_traverse_set_fact.py
src/bud/examples/example_time.py
Updated road-related functionality
  • Added 'all_roadunits_between' function
  • Modified 'get_sorted_required_arg_keys' function for efficiency
src/_road/test/test_road.py
src/gift/atom_config.py

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.