jschalk / jaar

Cross-cultural communication engine built on customizable economic systems. Produces personalized agendas, calendars, finance reports for users.
0 stars 1 forks source link

closes #306 #307

Closed jschalk closed 4 weeks ago

jschalk commented 4 weeks ago

Summary by Sourcery

Implement support for managing healer IDs within idea units, including the ability to insert and delete these IDs. Enhance the test suite to cover these new operations, ensuring the system's integrity and correctness.

New Features:

Tests:

sourcery-ai[bot] commented 4 weeks ago

Reviewer's Guide by Sourcery

This pull request implements functionality for managing healer holds in the idea unit, including adding and removing healer IDs. It also adds corresponding test cases for these new operations.

File-Level Changes

Change Details Files
Implement healer hold functionality for idea units
  • Add healer_id_str to function parameters
  • Implement _modify_bud_idea_healerhold_delete function
  • Implement _modify_bud_idea_healerhold_insert function
  • Add _modify_bud_idea_healerhold function to handle both insert and delete operations
  • Update modify_bud_with_atomunit to include healer hold modifications
src/gift/atom.py
Add test cases for healer hold operations
  • Implement test_ChangeUnit_get_edited_bud_ReturnsCorrectObj_BudUnit_insert_idea_healerhold
  • Implement test_ChangeUnit_get_edited_bud_ReturnsCorrectObj_BudUnit_delete_idea_healerhold
  • Add healer_id_str to function parameters
src/gift/test_change/test_change_after_bud.py

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.