jschalk / jaar

Cross-cultural communication engine built on customizable economic systems. Produces personalized agendas, calendars, finance reports for users.
0 stars 1 forks source link

closes #298 stone with multiple categorys #313

Closed jschalk closed 2 months ago

jschalk commented 2 months ago

Summary by Sourcery

Add a new stone format 'stone_format_00036_problem_healer_v0_0_0' and its configuration. Enhance the '_set_python_types' method to handle road creation. Introduce new tests to verify change unit creation and atom unit retrieval with multiple categories.

New Features:

Enhancements:

Tests:

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request implements support for stones with multiple categories, specifically adding functionality for the 'bud_idea_healerhold' category alongside 'bud_ideaunit'. The changes include updates to test cases, modifications to the AtomRow class, and the introduction of a new stone format for problem healers.

File-Level Changes

Change Details Files
Added support for multiple categories in stones
  • Updated AtomRow class to handle multiple categories
  • Modified get_atomunits method to return multiple AtomUnits for different categories
  • Added new test cases for multiple category scenarios
src/gift/test_atom/test_atom_row.py
src/gift/atom.py
Introduced new stone format for problem healers
  • Added stone_format_00036_problem_healer_v0_0_0 function
  • Updated get_stone_filenames and get_stone_format_headers to include the new format
  • Created new JSON file for stone_format_00036_problem_healer_v0_0_0
src/stone/stone_config.py
src/stone/stone_formats/stone_format_00036_problem_healer_v0_0_0.json
Enhanced AtomRow functionality
  • Added automatic road generation in _set_python_types method
  • Updated test cases to reflect new behavior
src/gift/atom.py
src/gift/test_atom/test_atom_row.py
Updated test cases for stone format changes
  • Modified assertions in test_get_stone_format_headers_ReturnsObj
  • Added new test case for create_changeunit with multiple categories
src/stone/test_stone/test_stone_format_config.py
src/stone/test_stone/test_stone_format_generate_stone.py

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.