Closed jschalk closed 1 week ago
This pull request implements a major refactoring to rename the "filter" concept to "pidgin" throughout the codebase. The change includes renaming files, classes, functions, and variables while preserving the core functionality. The refactoring also includes some improvements to the data model by renaming "obj_class" to "jaar_type" for better clarity.
classDiagram
class PidginUnit {
+TimeLinePoint eon_id
+OwnerID face_id
+dict[str, BridgeUnit] bridgeunits
+set_bridgeunit(BridgeUnit x_bridgeunit)
+get_bridgeunit(str x_jaar_type) BridgeUnit
+is_valid() bool
+set_otx_to_inx(str x_jaar_type, str x_otx, str x_inx)
+_get_inx_value(str x_jaar_type, str x_otx) str
+otx_to_inx_exists(str x_jaar_type, str x_otx, str x_inx) bool
+del_otx_to_inx(str x_jaar_type, str x_otx)
+set_explicit_label(str x_jaar_type, str x_otx, str x_inx)
+_get_explicit_inx_label(str x_jaar_type, str x_otx) str
+explicit_label_exists(str x_jaar_type, str x_otx, str x_inx) bool
+del_explicit_label(str x_jaar_type, str x_otx)
+get_dict() dict
+get_json() str
}
class BridgeUnit {
+str otx_road_delimiter
+str inx_road_delimiter
+dict explicit_label
+str jaar_type
+OwnerID face_id
+set_all_otx_to_inx()
+get_create_inx(str otx_word, bool missing_add) str
+_get_inx_value(str otx_word) str
+set_explicit_label(RoadNode otx_label, RoadNode inx_label)
+_set_new_explicit_label_to_otx_inx(otx_label, inx_label)
+_inx_road_delimiter_in_inx_words() bool
+_is_otx_delimiter_inclusion_correct() bool
+_is_inx_delimiter_inclusion_correct() bool
+all_otx_parent_roads_exist() bool
+is_valid() bool
+get_dict() dict
+get_json() str
}
PidginUnit --> BridgeUnit
note for PidginUnit "Renamed from FilterUnit"
note for BridgeUnit "Renamed attribute obj_class to jaar_type"
Change | Details | Files |
---|---|---|
Rename 'filter' concept to 'pidgin' throughout the codebase |
|
src/f08_filter/* src/f08_pidgin/* src/f09_brick/brick_config.json src/f10_world/world.py |
Rename 'obj_class' to 'jaar_type' for improved clarity |
|
src/f04_gift/atom_config.json src/f07_fiscal/fiscal_config.json src/f09_brick/brick_models.py |
Refactor file handling functions for better naming consistency |
|
src/f00_instrument/file.py src/f00_instrument/test/test_file.py |
Summary by Sourcery
Refactor the codebase to replace 'obj_class' with 'jaar_type' and 'filterunit' with 'pidginunit' across various modules and test cases, enhancing consistency and clarity in the code.
Enhancements:
Tests: