Closed jschalk closed 1 week ago
This pull request implements a consistent naming change across the codebase, renaming variables and parameters from 'required_args'/'optional_args' to 'jkeys'/'jvalues' and 'eon_id' to 'event_id'. The changes aim to improve code clarity and maintain consistent terminology.
classDiagram
class AtomUnit {
- jkeys: str
- jvalues: str
+ is_jkeys_valid(): bool
+ is_jvalues_valid(): bool
}
class DeltaUnit {
+ add_atomunit(category: str, crud_str: str, jkeys: str, jvalues: str)
+ get_atomunit(crud_str: str, category: str, jkeys: list[str]): AtomUnit
}
class BudUnit {
+ add_acctunit(acct_id: str)
+ get_acct(acct_id: str)
}
class Membership {
+ credit_vote: int
+ debtit_vote: int
}
AtomUnit --> DeltaUnit
DeltaUnit --> BudUnit
BudUnit --> Membership
note for AtomUnit "Renamed parameters from 'required_args'/'optional_args' to 'jkeys'/'jvalues'"
note for DeltaUnit "Updated methods to use 'jkeys' and 'jvalues'"
Change | Details | Files |
---|---|---|
Renamed 'required_args' and 'optional_args' to 'jkeys' and 'jvalues' respectively throughout the codebase |
|
src/f04_gift/atom.py src/f04_gift/atom_config.json src/f04_gift/atom_config.py src/f04_gift/test_atom/test_atom_core.py src/f04_gift/test_atom/test_atom_config.py |
Renamed 'eon_id' to 'event_id' across the entire codebase |
|
src/f09_brick/brick_models.py src/f09_brick/brick_formats/*.json src/f08_pidgin/pidgin.py src/f10_world/test/test_world_*.py |
Summary by Sourcery
Refactor codebase to replace 'required_args' and 'optional_args' with 'jkeys' and 'jvalues' for better clarity and consistency. Update related test cases to align with these changes.
Enhancements:
Tests: