jsk-ros-pkg / jsk_aerial_robot

The platfrom for aerial robot (e.g. general multirotor, hydrus, di, dragon, etc)
http://www.jsk.t.u-tokyo.ac.jp/index-j.html
34 stars 34 forks source link

[Common Quadrotor] support the common quadrotor platform #546

Closed tongtybj closed 1 year ago

tongtybj commented 1 year ago

What is this

Refactor the whole system to support common quadrotor platforms.

tongtybj commented 1 year ago

@Takuzumi240

Please use this as the base for common quadrotors

sugikazu75 commented 1 year ago

@tongtybj I think we should merge these commits to master for new quadrotor users. I resolved conflits and fixed a little in this branch. Can you condsider merging? or are there any tasks remained?

tongtybj commented 1 year ago

@sugikazu75

Thank you for your reminder. I will refactor all commits before merging, since there are some unnecessary conflicts with master branch.

tongtybj commented 1 year ago

Mini Quadrotor:

Screenshot from 2023-09-12 17-04-10

tongtybj commented 1 year ago

@sugikazu75

I manually merged https://github.com/sugikazu75/jsk_aerial_robot/commit/7930401a664d27c6ccc2485af0348332e9524950 and https://github.com/sugikazu75/jsk_aerial_robot/commit/7930401a664d27c6ccc2485af0348332e9524950 .

tongtybj commented 1 year ago

@sugikazu75 Please also review this PR.

sugikazu75 commented 1 year ago

@tongtybj config file in hydrus package is used here. So I think mini_quadrotor package should depend on hydrus or place the same file in this package.

tongtybj commented 1 year ago

@sugikazu75

Thank you for your advice. Please check https://github.com/jsk-ros-pkg/jsk_aerial_robot/pull/546/commits/e72351f29fe48adc07ce71cf21da99bf7417c505 and https://github.com/jsk-ros-pkg/jsk_aerial_robot/pull/546/commits/3ed55e8bbe84020adca8376d6dbd50e41006a62b

sugikazu75 commented 1 year ago

LGTM