jsk-ros-pkg / jsk_aerial_robot

The platfrom for aerial robot (e.g. general multirotor, hydrus, di, dragon, etc)
http://www.jsk.t.u-tokyo.ac.jp/index-j.html
34 stars 34 forks source link

[Aerial Robot Control] landing, halt command during vel acc-based mode #553

Closed HarukiKozukapenguin closed 1 year ago

HarukiKozukapenguin commented 1 year ago

What is this

Debug in landing, halt command in XyControlMode =VEL_CONTROL_MODE, and ACC_CONTROL_MODE

Detail

tongtybj commented 1 year ago

@HarukiKozukapenguin

Very good!

Could you also add setXyControlMode(POS_CONTROL_MODE); in following parts:

HarukiKozukapenguin commented 1 year ago

I fixed.

HarukiKozukapenguin commented 1 year ago

I think we can solve this problem by setting setXyControlMode(POS_CONTROL_MODE); in call of setTargetXyFromCurrentState . Is there any comments of this solution?

tongtybj commented 1 year ago

I think we can solve this problem by setting setXyControlMode(POS_CONTROL_MODE); in call of setTargetXyFromCurrentState . Is there any comments of this solution?

Execellent! LGTM

HarukiKozukapenguin commented 1 year ago

Could you merge thjs PR to master branch?

tongtybj commented 1 year ago

@HarukiKozukapenguin

Why you close this PR !?

HarukiKozukapenguin commented 1 year ago

Sorry. I closed because I mistakenly thought this PR has already merged to main branch. I found that this has not merged to main branch yet, so I reopened.