[Aerial Robot Model][Underactuated][Plugin] fix the wrong args assignment for model constructor

jsk-ros-pkg / jsk_aerial_robot

The platfrom for aerial robot (e.g. general multirotor, hydrus, di, dragon, etc)

http://www.jsk.t.u-tokyo.ac.jp/index-j.html

34 stars 34 forks source link

Closed tongtybj closed 1 year ago

tongtybj commented 1 year ago

There is a bug while assigning the arg to the variable fixed_model_ while creating the instance for underactuated model.

Forget to assign the boolean value for fixed_model_ when creating the instance for underactuated model plugin.
Use aerial_robot_model::transformable::RobotModel instead of aerial_robot_model::RobotModel for planning in dragon model and control processes.

tongtybj commented 1 year ago

@sugikazu75

Please review this PR.

tongtybj commented 1 year ago

@sugikazu75

Can you approve this PR?

sugikazu75 commented 1 year ago

Yes, it looks good to me.

tongtybj commented 1 year ago

@sugikazu75

I mean, can you complete the review request that I sent to you by clicking the "approve" button?