search

jsk-ros-pkg / jsk_recognition

JSK perception ROS packages
https://github.com/jsk-ros-pkg/jsk_recognition
271 stars 189 forks source link

jsk_preception build is unstable due to cloning during the build process #1817

Closed tfoote closed 8 years ago

tfoote commented 8 years ago

This job is failing frequently due to cloning SLIC-Superpixels during the build. http://build.ros.org/view/Ibin_arm_uThf/job/Ibin_arm_uThf__jsk_perception__ubuntu_trusty_armhf__binary/

It's strongly recommended not to fetch resources during the build process as that means that your build process is reliant on having network connectivity as well as the remote server being available at the time of build.

Looking at that repo there appear to be only 2 files in the repo and they appear to be pretty static. As such I'd recommend simply copying them into the repo, and you can have a script to update them from upstream when and if there's a change of interest.

Also I'll note that there's no license which should be requested of upstream before it should be used either by cloning or by copying.

k-okada commented 8 years ago

thanks, I originally designed jsk_3rdparty repository to support this type of external library... Other solution is if we can use submodule ( https://github.com/ros-infrastructure/bloom/issues/217), we can apply https://github.com/jsk-ros-pkg/jsk_recognition/pull/1425 patch

◉ Kei Okada

On Fri, Aug 5, 2016 at 5:40 AM, Tully Foote notifications@github.com wrote:

This job is failing frequently due to cloning SLIC-Superpixels during the build. http://build.ros.org/view/Ibin_arm_uThf/job/Ibin_arm_ uThf__jsk_perceptionubuntu_trusty_armhfbinary/

It's strongly recommended not to fetch resources during the build process as that means that your build process is reliant on having network connectivity as well as the remote server being available at the time of build.

Looking at that repo there appear to be only 2 files in the repo and they appear to be pretty static. As such I'd recommend simply copying them into the repo, and you can have a script to update them from upstream when and if there's a change of interest.

Also I'll note that there's no license which should be requested of upstream before it should be used either by cloning or by copying.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jsk-ros-pkg/jsk_recognition/issues/1817, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3Kx1bBS1A4UBp45mhZGTQdoJriT2ks5qck5AgaJpZM4JdGcx .

wkentaro commented 8 years ago

Fixed?

tfoote commented 8 years ago

I don't think there's been any changes. The failure is intermittent, it looks to be ~ 75% of builds fail.

k-okada commented 8 years ago

@tfoote do you have plan to release new version of vcstools https://github.com/vcstools/vcstools ? if so, we can fix this very soon.

tfoote commented 8 years ago

@k-okada released

k-okada commented 8 years ago

thanks, create pr to solve this problem, thanks https://github.com/jsk-ros-pkg/jsk_recognition/pull/1851