search

jsk-ros-pkg / jsk_recognition

JSK perception ROS packages
https://github.com/jsk-ros-pkg/jsk_recognition
266 stars 188 forks source link

PanoramaInfo msg can have image height and width? #2752

Open knorth55 opened 1 year ago

knorth55 commented 1 year ago

rects_array_in_panorama_to_bounding_box_array node subscribe full panorama image, but it uses only image height and image width image.

https://github.com/jsk-ros-pkg/jsk_recognition/blob/master/jsk_perception/node_scripts/rect_array_in_panorama_to_bounding_box_array.py#L53-L68

But when the network connection is low, it is hard to subscribe full panorama image.

We thought PanoramaInfo msg can have image height and image width information

@sktometometo what do you think?

cc. @AyumuIwa

sktometometo commented 1 year ago

I didn't design PanoramaInfo without Image size since it is redundant, but it sounds good idea to put it in PanoramaInfo.

knorth55 commented 1 year ago

Thank you, I will make a PR. @sktometometo do you want to keep the current behavior and add new option? or just rewrite to subscribe only panorama info?

sktometometo commented 1 year ago

@knorth55 Let's make it simple. Please remove a subscriber of panorama image.

knorth55 commented 1 year ago

@sktometometo OK, I will

knorth55 commented 1 year ago

i made a PR #2753