search

jsmrtn / craftagram

Grab Instagram content through the Instagram Basic Display API
Other
14 stars 8 forks source link

No way to Authorise Craft, have to manually add access tokern #26

Closed shoored closed 4 years ago

shoored commented 4 years ago

After entering and saving the App ID and App Secret, both by environment variables, I do not get the "Authorise Craft" button, just a Save button. Therefor I have to generate a token in Instagram Basic Display - Basic Display page.

When I try to save that access token manually on production, I get a server error which seems to be about allowAdminChanges set to false.

Am I doing anything wrong in the workflow? I can save the token locally and push the update to production but I get the feeling something's wrong.

Craft 3.4.27 Craftagram 1.2.4

jsmrtn commented 4 years ago

Sorry about that @studiosyntax–we had a conditional that was checking APP_ID was set to 15 characters before it would show the Authorise Craft button, but since we've added the option to add this as an env var, this can obviously be less than 15 characters.

I've removed this limit for you now, so the button should be showing for you, if you update to 1.2.5. I'll leave this token open if you could confirm if this fixes for you.

shoored commented 4 years ago

Hey thanks for the quick reply. I can't seem to update to 1.2.5, should I use a non-pushed version or something special?

jsmrtn commented 4 years ago

Should be available now. If it doesn’t pull into Craft straight away you can increment your version in composer to 1.2.5 manually.

shoored commented 4 years ago

Thanks, it's there. Will report back asap!