search

jsmrtn / craftagram

Grab Instagram content through the Instagram Basic Display API
Other
14 stars 8 forks source link

feat: multi-site support for refresh token #63

Closed qrazi closed 4 months ago

qrazi commented 1 year ago

The previous implementation of the CraftagramService would exit if the first site did not have a configured long access token.

It would also return true if the API call to Instagram failed.

The console controller returned the raw bool value as well, which mean that true gets converted to 1 which shells interpret as "exited with an error".

Also fix some typos and unused namespace imports.

I know this breaks the previous behavior but I thought this might be more in line with the intended behavior. I made this PR for Craft 3 branch still, as the project I'm working on is still on 3.8. I'd be happy to also create this style PR for the v2 branch.

jsmrtn commented 4 months ago

Thanks for you work here – I'm going to close this as it targets Craft 3, and I'm pushing forward with supporting Craft 5 rather than providing retroactive support for version 3.