Add some additional ics2rem functionality.

jspricke / python-remind

Python library to convert between Remind and iCalendar

GNU General Public License v3.0

13 stars 6 forks source link

Add some additional ics2rem functionality. #6

Closed Xitian9 closed 7 years ago

Xitian9 commented 7 years ago

Add various functionality to ics2rem, including:

Add a tail to every MSG, which follows the summary and preceeds the description. This is intended to add things like ‘%b’ to the end of MSGs.
Add deltas for advance warning on dates, as well as deltas and repeats for times.

I've been doing these things with sed scripts so far, but that's clearly the wrong solution. I think this fix adds the functionality without adding too much complexity.

Xitian9 commented 7 years ago

Come to think of it, there may not be a need for the trepeat parameter, since it could just be bundled into the tdelta (they're both strings which are concatenated immediately after one another). It would add a bit to the cognitive load of determining what the parameters mean, but would simplify the code. Do others have opinions on which approach is best?

Xitian9 commented 7 years ago

Will do. Sorry for the bad commit style.

Do you have an opinion on merging the tdelta and trepeat parameters, or keeping them separate? Barring any objections, I'll just merge the two.

Xitian9 commented 7 years ago

Cleaning this up was messy enough that I've created a new pull request #7. Closing.