Fix service info being populated incorrectly

juju-solutions / interface-http

Interface layer for the basic http interface protocol

4 stars 7 forks source link

Closed Cynerva closed 5 years ago

Cynerva commented 5 years ago

Proposed fix for https://github.com/juju-solutions/interface-http/issues/18. I think the service['hosts'] = ... statement was indented wrong, occurring outside of the loop when it should have been inside it.

I'm still testing this.

Cynerva commented 5 years ago

On closer examination, I think we missed starting with an empty host_set on each iteration too.

Cynerva commented 5 years ago

Done testing, this fixed the issue for me. Ready for review.

hyperbolic2346 commented 5 years ago

LGTM