search

juju-solutions / interface-http

Interface layer for the basic http interface protocol
4 stars 7 forks source link

hostname and private-address as optional parameters to configure_website() #6

Closed merlijn-sebrechts closed 7 years ago

merlijn-sebrechts commented 7 years ago

Some charms are proxies for other charms. Examples of this are charms that deploy docker containers on an external docker host, or charms that manage an externally hosted service.

The machine where the Juju agent of a proxy charm runs might not be the machine where the actual application is running. For this reason, proxy charms might want to supply a custom hostname and private address. This patch makes that possible.

merlijn-sebrechts commented 7 years ago

An example of such a proxy charm: https://github.com/ibcnservices/layer-limeds

AdamIsrael commented 7 years ago

Hey Merlijn,

Sorry for the long wait!

I don't see any issues with this change, nor should it interfere with existing implementations. Thanks for your work on this.