julianharty / app-store-reviews-app

Android App to analyse reviews and scripts to load historical reviews data into a SQLite database.
Apache License 2.0
3 stars 5 forks source link

Fix SQL Create Bugs #3

Open dakkad opened 7 years ago

dakkad commented 7 years ago

The SQL create statement has some bugs in it's data type definition.

julianharty commented 7 years ago

I agree, the create statement in the python does have some bugs, at the time I wasn't aware of how SQLite uses dynamic typing and was able to cope regardless of the mistakes (which I learned from following some example code online at the time). I've applied what I've learned subsequently to the create statement in the Android codebase. I'd prefer SQLlite to support date & time explicitly and unambiguously, however it seems it can coerce the incoming time/date fields into three file types. A good working example is http://www.sqlitetutorial.net/sqlite-date/

Additional references/sources include the following for SQLlite: https://www.sqlite.org/datatype3.html#affinity_name_examples https://www.sqlite.org/lang_datefunc.html http://www.sqlitetutorial.net/sqlite-data-types/

and the following for SQL generally http://code.openark.org/blog/mysql/timestamp-vs-datetime-which-should-i-be-using http://oracle.readthedocs.io/en/latest/sql/basics/style-guide.html

Thanks for the observation. I'll update the python code shortly.