Hokus on mac - Githubissues

julianoappelklein / hokus

A modern CMS for Hugo

https://www.hokuscms.com/

MIT License

607 stars 43 forks source link

Hokus on mac #18

Closed pvlrmnnk closed 5 years ago

pvlrmnnk commented 5 years ago

I managed to build hokus on my mac, but I had to install rimraf and electron-builder with npm globally. I don't have enough expertise to be sure that that's ok. So I need your assistance. A little bit later I'll create MR to add mac section to doc and package.json.

julianoappelklein commented 5 years ago

Hello @pavlunya,

Your contributtion is very appreciated.

The rimraf lib should be a dev dependency. This must be changed in the file package.json.

I forgot to include it. You can do this in your PR, if you want.

The electron-builder is correctly set as dev dependency, so it should not be required to be installed globally. But I don't think this affects the resulting installer and you can put a note in the build instructions you had to do it.

And how about the application? Is working well on mac? I have doubts if the automatic hugo download process will work.

Can you write the build steps here first? I'm curious.

PS: I don't have a mac.

pvlrmnnk commented 5 years ago

Well, I had not install something special, only node package (with brew). The minimum requirements is something that I should check, because I have a lot of stuff already installed.

Basically

brew install node
npm install
npm run dist-mac

screen shot 2018-11-22 at 3 41 15 pm

App has some glitches while scaling, but looks like it works just fine. I need a little bit more time to test.

As you can see hugo is installed. I thought It will use system installed instance, but I'm ok with that.

julianoappelklein commented 5 years ago

Hokus handles Hugo version by project. You have to declare the version in the hokus.yaml file. This way you can ensure compatibility.

About the code, push what you have. We can improve it later. Don't worry about the details. If something is missing, someone else can report it. Half solution is better than none.

I'm always improving the readme file.

Looking forward for your PR.

vendhana commented 5 years ago

@pavlunya - Can you please push the changes? Have you got the icon.png with 512*512?

I packaged the app in mac using the master but facing below issue due to image size image /Users/XXXXX/WS/git/hokus/public/icon.png must be at least 512x512

julianoappelklein commented 5 years ago

@vendhana, maybe this can help you: Hokus CMS PNG Icon 512x512

I'm here to help with whatever I can.

vendhana commented 5 years ago

@pavlunya & @julianoappelklein - Created PR to include mac support. Can we close this issue after PR is closed?

julianoappelklein commented 5 years ago

Pull request merged. I'll close this one.

@pavlunya, thank you very for opening the issue. Helped a lot. Now I'm considering to use Travis CI to build releases for all platforms regularly.

@vendhana, your PR was almost perfect. I've accepted it and after fixed the URL thing in the package.json.

pvlrmnnk commented 5 years ago

I had a vacation. So sorry that I missed this opportunity to help.

julianoappelklein commented 5 years ago

Dude, you've helped!

julianoappelklein commented 5 years ago

@pavlunya, @vendhana - now we have a mac release. Thanks to you. https://github.com/julianoappelklein/hokus/releases/tag/0.4.0