search

julien-f / csv2json

Simple and fast streaming CSV to JSON converter
36 stars 9 forks source link

csv2json only returns a stream and not the JSON #38

Open KunalBurangi opened 1 year ago

KunalBurangi commented 1 year ago

Hi @julien-f , I have created a pull request with some code changes. PR/37 1) one problem I saw was that the function csv2json only returns a stream and not the JSON, so creating a JSON object becomes very complicated even after using the module.. Now it directly returns JSON data.. 2) Added an example.js file 3) Added a test file... 4) Added jsonDoc What do you think about it ? If you think this is a good idea then i ll modify this to support cli as well

KunalBurangi commented 1 year ago

@julien-f can you please suggest