junethack / Junethack

Junethack inter-server nethack tournament
Other
21 stars 9 forks source link

dNethack trophy names and new trophies #70

Closed Chris-plus-alphanumericgibberish closed 3 years ago

Chris-plus-alphanumericgibberish commented 3 years ago

Link to CSV: https://github.com/Chris-plus-alphanumericgibberish/dNAO/blob/compat-3.21.0/junethack_trophies/trophy_descriptions.csv

dNethack has one new role this year: the Madman (file code "Mad"), which will need to be added to the dNethack Tour trophy (I'm going to create a second suggesting the removal of the dNethack prince and king trophies, the tour one I kind of like the idea of).

All trophies now have names listed (which is clearly the important part, not the artwork <_<). I've separated out the new trophies from the old ones.

The first three trophies are straightforward achieveX tags, the first for finishing the Madman quest, the other two for defeating Lamashtu and Baalphegor (it seemed odd that Demogorgon and Asmodeus had trophies but those two didn't).

The last pair of trophies is a bit more complex, but I think still straightforward to add. There is a set of three _vault achieveX tags, and I'm proposing giving out the first trophy when a player earns any one of those tags, and the second trophy once a player has earned all three of those tags (across however many games that takes). If that's not actually straightforward to handle, there could just as easily be one trophy per _vault flag.

bhaak commented 3 years ago

Oops. Forgot to close this one. Should be working with e26fc77ec4ffb870030dd6ac2c2e360e8fba9ac0