search

jup-ag / terminal

Jupiter Terminal is an open-sourced, lite version of Jupiter that provides end-to-end swap flow by linking it in your HTML.
https://terminal.jup.ag
82 stars 46 forks source link

[1.0.8] Bug wallet standard conflict with existing WalletProvider #40

Closed worlddlckgh closed 1 year ago

worlddlckgh commented 1 year ago

This bug only happens on site with built-in <WalletProvider /> and Terminal instance, and interfacing with WalletStandard.

  1. most wallet extension have internal checking and handling of connecting, therefore connection seems "handled"
  2. Phantom may trigger twice if the prompt is rejected, due to dApp and Terminal eagerly trying to autoConnect

Therefore, By not rendering <WalletProvider /> when passthroughWallet is provided, Terminal will no longer eagerly trying to get attention.

Thanks to Pika pika @Arrowana for filing the bug.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
jupiter-terminal ✅ Ready (Inspect) Visit Preview Aug 29, 2023 7:33am
worlddlckgh commented 1 year ago

Closing, and merging this into V2