jup-ag / terminal

Jupiter Terminal is an open-sourced, lite version of Jupiter that provides end-to-end swap flow by linking it in your HTML.
https://terminal.jup.ag
70 stars 34 forks source link

Support market prioritization fee #55

Closed michael-lcs closed 5 months ago

michael-lcs commented 5 months ago

Description

Support market prioritization fee in Terminal

Screenshots

UI Update

Screenshot 2024-01-21 at 11 57 43 PM

POST /swap payload update

Screenshot 2024-01-21 at 11 59 29 PM
vercel[bot] commented 5 months ago

Someone is attempting to deploy a commit to the wowcats Team on Vercel.

A member of the Team first needs to authorize it.

worlddlckgh commented 5 months ago

Let's have slightly more margin-top mt-1 or mt-2 is enough image

worlddlckgh commented 5 months ago

https://github.com/jup-ag/terminal/assets/34560707/a22f1fc6-9c39-4cde-9187-a2d9a5357246

the button "jumps" a little when being clicked, can you set border-transparent as the non-active state, so it will keep occupy the space and won't jump?

worlddlckgh commented 5 months ago

I think there's several things we need to do to make the experience better.

worlddlckgh commented 5 months ago

There's a bug for prioritization fee, to repro:

image

michael-lcs commented 5 months ago

There's a bug for prioritization fee, to repro:

  • Open the settings dialog
  • select Turbo market fees
  • perform 1st swap
  • Then, open settings dialog, set Market fees
  • you can see the /swap is called with the "Turbo" instead of "market"

image

Fixed

michael-lcs commented 5 months ago

this is how the each Setting modal and Terminal looks like after update.

Terminal

Screenshot 2024-01-22 at 11 59 19 PM

Setting Modals

Priority Slippage General
Screenshot 2024-01-22 at 11 54 21 PM Screenshot 2024-01-22 at 11 54 26 PM Screenshot 2024-01-22 at 11 54 32 PM.
worlddlckgh commented 5 months ago

Hey 👋 Thank you for contributing, we'll take into prioritization-fee branch, and take over from there!