feat: add rebinding of keys

jupjohn / LethalCompany-NoiseSuppression

Enables noise suppression on microphones in Lethal Company

https://thunderstore.io/c/lethal-company/p/jammeh/NoiseSuppression/

MIT License

1 stars 1 forks source link

feat: add rebinding of keys #1

Open jupjohn opened 7 months ago

jupjohn commented 7 months ago

Currently all of the key codes are hardcoded/stored in a config file. It would be ideal if we could hook into the keybinds menu to allow users to adjust them.

Current keysbinds:

0: toggles noise suppression
8: decreases noise suppression/raw audio mix by 10%
9: increases noise suppression/raw audio mix by 10%
PageUp: enables noise suppression
PageDown: disables noise suppression

hazzuk commented 6 months ago

Hi there, great mod! My friends microphone no longer drive me insane using noise suppression. I wanted to add some suggestions for this feature:

Please add support for the widely used LethalCompany InputUtils, which adds a user accessible keybinds menu.
Additionally, please allow for your keybinds to go unbound. I don't need to bind three different keys for toggle, enable and disable. Toggle on its own is all I need. Currently if I leave a binding blank or set to None, mod throws continuous errors.

jupjohn commented 6 months ago

Thanks for the suggestions, @SirHazza! I've neglected this mod so haven't got around to implementing this, but I'll take a look into the InputUtils library you've mentioned this weekend and try to get something out.

The reason why you can use PageUp/PageDown to change the activation is because there's no real feedback from pressing the toggle key at the moment - meaning you have no idea if it's enabled or not. Those keys were just a fallback to make sure it's in a state you expect it to be. I'm keen to remove those keybinds once I have some kind of feedback in place (even if it's just an audio notification).

Thanks for reminding me that this project exists :D