search

jupyterlab-contrib / jupyterlab-tour

A JupyterLab UI tour built on jupyterlab-tutorial and react-joyride.
BSD 3-Clause "New" or "Revised" License
62 stars 9 forks source link

Support JupyterLab 4, Notebook 7 #76

Closed bollwyvl closed 11 months ago

bollwyvl commented 1 year ago

Is your feature request related to a problem? Please describe.

This package doesn't have an upper bound on its jupyterlab, but also doesn't support JupyterLab 4

Describe the solution you'd like

a new release line that only supports JupyterLab 4/Notebook 7

Describe alternatives you've considered

a release that supports JupyterLab 3 and JupyterLab 4 and Notebook 7. This is probably harder.

Additional context

It would be nice to get #29 into it, but wouldn't strictly be blocking.

jtpio commented 11 months ago

Closing as this seems to have been fixed by https://github.com/jupyterlab-contrib/jupyterlab-tour/pull/75, https://github.com/jupyterlab-contrib/jupyterlab-tour/pull/71, and released in https://github.com/jupyterlab-contrib/jupyterlab-tour/releases/tag/v4.0.0.

jtpio commented 11 months ago

While it might be working in JupyterLab 4 and Notebook 7, looks like we lost JupyterLite support on the way: https://github.com/jupyterlab-contrib/jupyterlab-tour/pull/81#issuecomment-1832268381

jtpio commented 11 months ago

Opened https://github.com/jupyterlab-contrib/jupyterlab-tour/issues/82