jvandemo / generator-angular2-library

Yeoman generator to create an Angular library
MIT License
752 stars 122 forks source link

Add support for namespaces #264

Open broweratcognitecdotcom opened 6 years ago

broweratcognitecdotcom commented 6 years ago

We constantly have to edit package.json files and tsconfig.es5.json because we use a company namespace, examples: @cognitec/ui, @cognitec/authentication, etc.

When I want to use the generator, I am in .../@cognitec/ folder. I typically mkdir, example: mkdir ui then I run the generator, e.g. yo angular2-library and I enter in the name of the package, e.g. @cognitec/ui but this results in a flat module ID of cognitec-ui instead of what we need.

It would be wicked awesome if the generator was capable of figuring out from the package name that the user enters, e.g. @cognitec/ui, that the user is in the @cognitec folder and proceeded to create the ui folder, and package.json and tsconfig.es5.json files that contained @cognitec/ui as the package name and flat module ID.

Thanks for this excellent generator. It has been invaluable to us.

izifortune commented 6 years ago

Hi @broweratcognitecdotcom i'm doing this already in a customised version of the generator i'm happy to share it in a PR

broweratcognitecdotcom commented 6 years ago

@izifortune Sweet. Please do.

adamk33n3r commented 6 years ago

@izifortune Any update on this? I would love to have this enhancement.

izifortune commented 6 years ago

Sorry @Adam I will make some time this week to share this

izifortune commented 6 years ago

Hi @adamk33n3r please have a look at this PR #283. Hope i'm not missing anything there

jvandemo commented 6 years ago

@izifortune — Thank you for your follow-up, much appreciated! 🏆