search

jvandemo / generator-angular2-library

Yeoman generator to create an Angular library
MIT License
752 stars 122 forks source link

update rollup config for newer version reqs #270

Closed zgabievi closed 6 years ago

zgabievi commented 6 years ago

The following options have been renamed — please update your config: name -> output.name, globals -> output.globals, format -> output.format, exports -> output.exports

jvandemo commented 6 years ago

@zgabievi — Thank you for your contribution.

Does the change require a specific version of rollup? If so, is an update package.json needed to ensure the config does not break for people with older versions of rollup?

Thanks in advance!

zgabievi commented 6 years ago

I have not tested it but I’m pretty sure it will break on old versions. But what’s the difference if its broken on newer version. I think it’s better to keep config up to date. But you are boss. You should decide ;)

jvandemo commented 6 years ago

@zgabievi Since which version of rollup has the config format changed to the format in your PR? Then we can update package.json accordingly. Thanks in advance!

zgabievi commented 6 years ago

Since 0.48.0. Check the gist for example of options format: https://gist.github.com/Rich-Harris/d472c50732dab03efeb37472b08a3f32

jvandemo commented 6 years ago

@zgabievi — Thank you for your contribution! 🏆 @izifortune — Thank you for your review 👍

jvandemo commented 6 years ago

Changes have been released as v12.3.0 👍

zgabievi commented 6 years ago

@jvandemo You are welcome 👍

jvandemo commented 6 years ago

@zgabievi — 🏆 👍