search

jyundt / oval

The Oval
https://theoval.us
GNU General Public License v2.0
1 stars 0 forks source link

Default to the "staging" branch for test deployment #57

Closed johnwheffner closed 7 years ago

johnwheffner commented 7 years ago

This feels like the wrong way to do it. Tying type of deployment to host this way feels awkward. Thoughts?

jyundt commented 7 years ago

Yeah, I wouldn't specify the git branch based on hostname. I would continue to deploy "release" to test.theoval.us and you can always manually override that variable using the ansible-playbook CLI.

That's how I've typically tested different branches/releases when deploying to test.theoval.us

I'm leaning towards "no" for this PR.

johnwheffner commented 7 years ago

What's the right thing in the ansible model -- different roles for release and staging?

jyundt commented 7 years ago

Based on some slack discussion, closing this PR and keeping the release model as/is for test.theoval.us.