issues
search
jyundt
/
oval
The Oval
https://theoval.us
GNU General Public License v2.0
1
stars
0
forks
source link
Add initial S3 upload/download/view functionality
#94
Closed
jyundt
closed
7 years ago
jyundt
commented
7 years ago
Fixes #92
jyundt
commented
7 years ago
A few comments:
This PR is very light on error checking (all S3 failures are logged, but only to the audit log on the server)
I'm using the md5 of the file as the S3 key (e.g. filename).
I did this in order to avoid potential conflicts between identical file names
I'm not sure I like the additional UI buttons for download/view (it seems cluttered) but I don't really care too much
@johnwheffner lemme know your thoughts
Fixes #92