k2-fsa / snowfall

Moved to https://github.com/k2-fsa/icefall
Apache License 2.0
143 stars 42 forks source link

Rotary positional embeddings for conformer #235

Open pzelasko opened 3 years ago

pzelasko commented 3 years ago

Just throwing the idea around in case somebody wants to pick it up, I wanted to do it for some time but can't find the time. There's a new position embedding type called RoPE that yield improvements across different NLP tasks and now also ASR. Shouldn't be too difficult to add, and there is an implementation here: https://github.com/lucidrains/rotary-embedding-torch

Original paper: https://arxiv.org/abs/2104.09864 Application in ASR: https://arxiv.org/abs/2107.05907