search

k2-fsa / snowfall

Moved to https://github.com/k2-fsa/icefall
Apache License 2.0
143 stars 42 forks source link

To be more Pythonic #49

Open csukuangfj opened 3 years ago

csukuangfj commented 3 years ago

There exist shell scripts and Perl scripts for data preparation, most of which are modified from Kaldi. They provide extra functionalities that are actually not needed in snowfall.

I would suggest doing as many things as possible in Python and getting rid of shell scripts and Perl scripts as best as we can.

danpovey commented 3 years ago

Sure, but bear in mind that the whole idea of Snowfall (vs. Icefall) is "move fast and break things". At this point our main goal is to get a prototype working and debug k2 and lhotse, so while eventually we'll want to do things more Pythonically, let's not prioritize it too highly.

pzelasko commented 3 years ago

+1 to what both of you are saying. These scripts are also on my radar, but I'm refraining myself from touching that as I'd prefer to contribute to a working recipe first :)