Dipping potion of acid in fountain causes heap-use-after-free

k21971 / EvilHack

A variant of NetHack that is designed to be a much more challenging experience than the original, drawing inspiration and content from various existing variants along with adding unique and never-before-seen custom content.

Other

53 stars 22 forks source link

Dipping potion of acid in fountain causes heap-use-after-free #107

Closed elunna closed 1 year ago

elunna commented 1 year ago

In fountain.c: dipfountain()

Change if (obj->otyp == POT_ACID && er != ER_DESTROYED) { / Acid and water don't mix / to if (er != ER_DESTROYED && obj->otyp == POT_ACID) { / Acid and water don't mix /

k21971 commented 1 year ago

See https://github.com/NetHack/NetHack/pull/936/files

k21971 commented 1 year ago

Fixed via commit 5329bf2.