search

k21971 / EvilHack

A variant of NetHack that is designed to be a much more challenging experience than the original, drawing inspiration and content from various existing variants along with adding unique and never-before-seen custom content.
Other
53 stars 22 forks source link

Fix: Silver dragon scaled armor was not granting cold resistance. #135

Closed elunna closed 1 year ago

elunna commented 1 year ago

On the EvilHack wiki I noticed it says it grants cold res.

This is my first PR, do I usually target the master branch?

k21971 commented 1 year ago

Hi! Yes, targeting the master branch is fine.

Also, you can close this PR... thanks though! I purposely removed silver dragon scales imparting cold resistance a ways back in commit 82ba30c - if it's still reporting this on the wiki, it's wrong.

k21971 commented 1 year ago

Hold up, don't close it. Lemme think on it. I need to talk to past me and see what he was thinking.

elunna commented 1 year ago

Ok ok - I thought it made sense because silver dragons breathe cold :)

k21971 commented 1 year ago

I think past me pulled cold res away from silver dragons because I did the same for gold dragons/fire res. But gold dragons have a secondary intrinsic (sick res) and silver dragons haven't had one at all since Feb 2022. Since they have a cold breath attack, it would make sense that it be returned.