feat: add proxysettings for azureopenai and openai

k8sgpt-ai / k8sgpt-operator

Automatic SRE Superpowers within your Kubernetes cluster

https://k8sgpt.ai

Apache License 2.0

300 stars 85 forks source link

feat: add proxysettings for azureopenai and openai #415

Closed tanujd11 closed 3 weeks ago

tanujd11 commented 5 months ago

Closes https://github.com/k8sgpt-ai/k8sgpt-operator/issues/307

📑 Description

This PR adds proxyEndpoint to be configured from the operator. The feature was provided by https://github.com/k8sgpt-ai/k8sgpt/pull/987 in k8sgpt.

✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[ ] I have updated the documentation as required
[x] All the tests have passed

ℹ Additional Information

lawrencelo commented 5 months ago

We are waiting for this proxy setting feature in next k8sgpt-operator release. Currently it does not take proxyEndpoint in k8sgpt CRD spec. Thanks in advance for moving this forward.

tanujd11 commented 5 months ago

You have to update manually the helm's chart CRD template to include the

@arbreezy I have already did the change in the file you mentioned. PTAL.

arbreezy commented 5 months ago

You have to update manually the helm's chart CRD template to include the

@arbreezy I have already did the change in the file you mentioned. PTAL.

you are right, the only pending update is to add the new spec attribute in the README

arbreezy commented 5 months ago

@tanujd11 just bumping a message, changes lgtm but please update README's example to include the new spec attribute you are creating :pray:

tanujd11 commented 4 weeks ago

@arbreezy, Could you take a look? I have updated the Readme.

tanujd11 commented 4 weeks ago

Can this be merged now?