search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

update deprecated api version #141

Closed pperiyasamy closed 4 years ago

pperiyasamy commented 4 years ago

This updates ClusterRole/ClusterRoleBinding kind apiVersion into v1because v1beta1 is already deprecated in K8s 1.17 and deployment of ovs-cni.yml throws below warning.

Warning: rbac.authorization.k8s.io/v1beta1 ClusterRole is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRole
Warning: rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding

Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech

pperiyasamy commented 4 years ago

/release-note-none

pperiyasamy commented 4 years ago

These files are generated based on https://github.com/kubevirt/ovs-cni/blob/master/manifests/ovs-cni.yml.in#L81. Would you please update the source and run make manifests?

ah! yes, now updated the source file as well.

pperiyasamy commented 4 years ago

/cc @JanScheurich

kubevirt-bot commented 4 years ago

@pperiyasamy: GitHub didn't allow me to request PR reviews from the following users: JanScheurich.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubevirt/ovs-cni/pull/141#issuecomment-734189798): >/cc @JanScheurich Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 4 years ago

Thanks!

/lgtm /approve

kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ovs-cni/blob/master/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment