kaajjo / LibreSudoku

LibreSudoku - Sudoku app for android built with Kotlin + Jetpack Compose + Material3
GNU General Public License v3.0
412 stars 31 forks source link

Exclude initial number interaction as a user action #33

Closed nvllz closed 1 year ago

nvllz commented 1 year ago

If you try to replace an initial number by selecting a cell and clicking on any number in the bottom bar, it won't affect the number because they are not overwritable. But it still counts as a user action. You can see this by trying to undo your input, which will try to undo changes that were never made to the initial numbers every time you tap Undo.

To reproduce:

  1. Start a new game and fill any empty cell with any number on the grid
  2. Select any initial digit cell and try to overwrite it with a random digit x times (it won't affect the cell)
  3. Tap the Undo button

You are expecting the button to undo a visible change made in the first step, and instead you need to tap the Undo button x+1 times to undo a visible action. To fix this, make the interaction with the initial numbers not count as a user action.

nvllz commented 1 year ago

Looks like it didn't fix the problem.

kaajjo commented 1 year ago

yep, not fixed in cell first input mode